Fix packaging workflows - #1340
Conversation
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D96389339. (Because this pull request was imported automatically, there will not be any future comments.) |
9295ef9 to
a972d6b
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
a972d6b to
adfaaa9
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
What's the status of this? |
adfaaa9 to
9a6635c
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
@ofek This is waiting on upstream review. Until that happens one can trigger the updated workflows from a forked repo to get a recent build. |
9a6635c to
eea3c49
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
My initial attempt at D90919043 only uncovered more failures, so try and fix the remaining ones: * Add missing entry for Ubuntu Noble to substcontrol.py. * Run `install-system-packages.sh` in a venv to workaround the unconditional `pip install pex` call from getdeps. `pex` isn't actually relevant to the watchman build so this just needs to not fail. * Reapply D93644456 so that we don't produce random shared libraries that conflict with system ones. This appears to have been unintentionally unfixed by D94714599. * Build fast_float from source on Fedora < 42. * Drop Fedora 40, add Fedora 43. * Update third-party workflow versions as we're here. Tested via: * https://github.com/mszabo-wikia/watchman/actions/runs/23025768943 * https://github.com/mszabo-wikia/watchman/actions/runs/23025768938
eea3c49 to
4e11b04
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
I'm not sure why CI is failing but thanks a lot for picking this back up! After releases are fixed I plan to use Watchman in our developer environments. |
|
@ofek should be fine now, seems like my patch first needed updating for facebook/folly@0d8c788 and the failure after that was just a random workflow cancellation. |
|
We also OSS our watchman hermetic build pipeline here. Happy to PR this pipeline to |
Nice, this is pretty handy. Personally I feel the Bazel build is better left as a standalone project, because PRing it here will give the impression it's officially supported. That won't be the case, so once it breaks, any fixes would need to be submitted by willing external contributors through PRs with a possibly significant review delay. |
|
yeah understood. Meta already uses Buck which is quite close to bazel so I'm honestly surprised it's not used in this repo. |
|
AFAICT some repos have published their BUCK build files and have Buck-based CI workflows in various states of breakage but as of late I haven't seen any concerted effort to achieve parity with CMake builds across fboss. |
3 participants
My initial attempt at D90919043 only uncovered more failures, so try and fix the remaining ones:
install-system-packages.shin a venv to workaround the unconditionalpip install pexcall from getdeps.pexisn't actually relevant to the watchman build so this just needs to not fail.Tested via:
Fixes #1339, fixes #1337, fixes #1335, fixes #1301, fixes #1299, fixes #1282, fixes #1280, fixes #1256