Skip to content

fix(unplugin): serialize concurrent CSS writes in Bun plugin #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryuhzk wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Open

fix(unplugin): serialize concurrent CSS writes in Bun plugin #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/@stylexjs/unplugin/src/bun.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,22 @@ export const createStylexBunPlugin = (userOptions = {}) => {
options.bunDevCssOutput ||
path.resolve(process.cwd(), 'dist', 'stylex.dev.css');
let lastCss = null;
let writeQueue = Promise.resolve();

const writeCss = async () => {
const writeCss = (force = false) => {
const css = plugin.__stylexCollectCss?.() || '';
const next = css
? `:root { --stylex-injection: 0; }\n${css}`
: ':root { --stylex-injection: 0; }';
if (next === lastCss) return;
if (!force && next === lastCss) return writeQueue;
lastCss = next;
try {
await fsp.mkdir(path.dirname(cssOutput), { recursive: true });
await fsp.writeFile(cssOutput, next, 'utf8');
} catch {}
writeQueue = writeQueue
.then(async () => {
await fsp.mkdir(path.dirname(cssOutput), { recursive: true });
await fsp.writeFile(cssOutput, next, 'utf8');
})
.catch(() => {});
return writeQueue;
};

return {
Expand All @@ -59,11 +63,11 @@ export const createStylexBunPlugin = (userOptions = {}) => {
if (plugin.buildEnd) {
build.onEnd(async () => {
await plugin.buildEnd();
await writeCss();
await writeCss(true);
});
} else {
build.onEnd(async () => {
await writeCss();
await writeCss(true);
});
}

Expand Down