Skip to content

docs: fix dead links to the shared package - #1814

Open
rajanpanth wants to merge 1 commit into
facebook:mainfrom
rajanpanth:docs/fix-dead-shared-package-links
Open

docs: fix dead links to the shared package#1814
rajanpanth wants to merge 1 commit into
facebook:mainfrom
rajanpanth:docs/fix-dead-shared-package-links

Conversation

@rajanpanth

Copy link
Copy Markdown

Two README links to the @stylexjs/shared package 404, both treating shared as a directory inside babel-plugin when it's actually a sibling package:

File Old (404) New (200)
README.md blob/main/packages/@stylexjs/babel-plugin/shared tree/main/packages/@stylexjs/shared
packages/@stylexjs/eslint-plugin/README.md .../babel-plugin/src/shared/utils/property-priorities.js .../shared/src/utils/property-priorities.js

The root README one also used /blob/ for a directory; that's now /tree/.

The eslint-plugin link matters most — it's the reference readers follow to understand the sort-keys rule's property ordering, and right now it goes nowhere.

shared is a sibling package of babel-plugin, not a directory inside it,
so both links 404.
@rajanpanth
rajanpanth requested a review from mellyeliu as a code owner August 19, 2026 12:37
Copilot AI lite review requested due to automatic review settings August 19, 2026 12:37
@rajanpanth
rajanpanth requested a review from nmn as a code owner August 19, 2026 12:37
@meta-cla

meta-cla Bot commented Aug 19, 2026

Copy link
Copy Markdown

Hi @rajanpanth!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

@rajanpanth is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2026
@meta-cla

meta-cla Bot commented Aug 25, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants