Skip to content

Limit Pixi atlas size #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KTibow wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −14
Open

Limit Pixi atlas size #1817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions modules/pixi/PixiTextures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,9 @@ export class PixiTextures {
const renderer = gfx.pixi.renderer;
registerAtlasUploader(renderer);

// Try to get the max texture size.
// We will prefer large atlas size of 8192 to avoid texture swapping, but can settle for less.
const trysize = 8192;
let maxsize = 2048; // a reasonable default
if (gfx.highQuality) {
if (renderer.type === PIXI.RendererType.WEBGL) {
const gl = renderer.gl;
maxsize = gl.getParameter(gl.MAX_TEXTURE_SIZE);
} else if (renderer.type === PIXI.RendererType.WEBGPU) {
const gpu = renderer.gpu;
maxsize = gpu.adapter.limits.maxTextureDimension2D;
}
}
const size = Math.min(trysize, maxsize);
// Pixi's WebGL shaders use mediump fragment UVs, which only guarantee about
// 10 bits of precision and cannot reliably address larger normalized atlases.
const size = 2048;

// We store textures in 3 atlases, each one is for holding similar sized things.
// Each "atlas" manages its own store of "TextureSources" - real textures that upload to the GPU.
Expand Down