-
Notifications
You must be signed in to change notification settings - Fork 135
Use pixi.js/unsafe-eval polyfills to remove unsafe-eval CSP requirement #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
5
commits into
main
Choose a base branch
from
copilot/fix-unsafe-eval-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+615
−2
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b8c45d4
Initial plan
Copilot 5c7f762
Initial plan for CSP unsafe-eval fix
Copilot 4946a47
Fix: Import pixi.js/unsafe-eval polyfills to support strict CSP envir…
Copilot 72b8731
Clean up unnecessary .gitignore entry
Copilot b720e97
Fix `this` context in missing_role validation fix onClick handlers (#…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pixi.js/unsafe-evalneeds to be loaded before Pixi generates anynew Function()-based sync functions. In this codebase, several modules import frompixi.js(e.g.modules/core/AbstractSystem.js,modules/Context.js) beforeGraphicsSystem.jsis reached, so this import may not reliably run first. Consider moving the side-effect import to the earliest application entry module (or a dedicated Pixi bootstrap module that all Pixi imports depend on) to guarantee it executes before anypixi.jsimport/evaluation.