Repository navigation
Conversation
loichuder
commented
Mar 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
woutdenolf
requested changes
Mar 6, 2026
Comment on lines
6
to
7
Member
There was a problem hiding this comment.
These two files can be removed.
Member
There was a problem hiding this comment.
@loichuder You forgot to remove the files themselves.
Member
Author
|
Merging this to fix the nightly build over the week-end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #61 (comment)
I could not run
flake8_nblocally so I thought we might as well move toruff.ruffis smarter thanflake8_nband only raises an error if the import is not at the top of the cell rather than the file for notebooks (https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/).