Skip to content

📝 docs(test): follow-up scope for finishing the Anvil-to-Tevm migration - #3

Open
roninjin10 wants to merge 1 commit into
mainfrom
quality/viem-review
Open

📝 docs(test): follow-up scope for finishing the Anvil-to-Tevm migration#3
roninjin10 wants to merge 1 commit into
mainfrom
quality/viem-review

Conversation

@roninjin10

Copy link
Copy Markdown

Review-only PR. Adds test/FOLLOWUP-tevm-migration.md: a single markdown file, no code, no CI, no site changes.

Why

I reviewed PR #2 (Complete the Anvil-to-Tevm test migration, 291 files) and posted findings as comments there:

Headline: several of PR #2's "known issues" look like migration bugs rather than Tevm gaps, and conflating them risks writing off real defects.

Verified locally

On PR #2's branch (f8618fe), after pnpm install --ignore-scripts (exit 0, tevm 1.0.0-rc.151):

$ pnpm exec vitest run -c test/vitest.config.ts --project core \
    src/actions/wallet/requestAddresses.test.ts src/utils/signature/verifyTypedData.test.ts
 Test Files  2 failed (2)
      Tests  3 skipped (3)
     Errors  4 errors

$ VITE_TEVM_NO_FORK=true pnpm exec vitest run -c test/vitest.config.ts --project core \
    src/actions/wallet/requestAddresses.test.ts src/utils/signature/verifyTypedData.test.ts
 Test Files  2 passed (2)
      Tests  2 passed | 1 skipped (3)

Two files that need no fork state cannot run without an archive RPC, because isUsed() in test/src/tevm.ts is tripped by any property read rather than by actual node use.

Scope of this PR

Documentation only. site/ is untouched (vocs sources live under site/pages; this file is under test/), so the live docs build is unaffected. Nothing merged.

🤖 Generated with Claude Code

…ration

Companion to PR #2. Records the review triage (which reported failures are
genuine Tevm gaps vs. migration mistakes) and the sequenced plan for retiring
the opt-in Anvil transport lane once tevm wevm#2084 (WebSocket) and wevm#2080 (IPC)
publish to npm.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant