Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions packages/lib/component-utilities/src/dateParsing.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,17 @@ export function convertColumnToDate(data, column) {

data = tidy(
data,
mutate({ [column]: (d) => (d[column] ? new Date(standardizeDateString(d[column])) : null) })
mutate({
[column]: (d) => {

const raw = d[column]
if (raw === null | raw === '') return null
const standardized = standardizeDateString(raw)
const date = new Date(standardized)

return isNan(date.getTime()) ? null : date
}
})
);

return data;
Expand All @@ -45,7 +55,17 @@ export function standardizeDateColumn(data, column) {
// Replaces a date column's string values with standardized date strings, using the standardizeDateString function
// Used in Chart.svelte, where using Date objects leads to errors

data = tidy(data, mutate({ [column]: (d) => standardizeDateString(d[column]) }));
data = tidy(data, mutate({
[column]: (d) => {

const raw = d[column]
if (raw === null | raw === '') return null
const standardized = standardizeDateString(raw)
const date = new Date(standardized)

return isNan(date.getTime()) ? null : date
}
}));

return data;
}
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@
.filter((d) => d.type === 'date' && !(data[0]?.[d.id] instanceof Date))
.map((d) => d.id);

for (let i = 0; i < dateCols.length; i++) {
data = convertColumnToDate(data, dateCols[i]);
}
dateCols.forEach((col) => {
data = convertColumnToDate(data, col);
});

// Hide link column if columns have not been explicitly selected:
if (link) {
Expand Down
Loading