fix(websocket): set STOPPED_BIT before task create to avoid stop()/de…#1098
Open
gabsuren wants to merge 1 commit into
Open
fix(websocket): set STOPPED_BIT before task create to avoid stop()/de…#1098gabsuren wants to merge 1 commit into
gabsuren wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1096
Note
Medium Risk
Touches client start/stop synchronization in embedded networking code; incorrect bit ordering could cause hangs or premature teardown, but the change is small and targeted.
Overview
Fixes a lifecycle race in
esp_websocket_client_start()wherestop()ordestroy()could mis-handle a client that was mid-start or had a failed task spawn (see #1096).STOPPED_BITis cleared beforexTaskCreatePinnedToCore, so callers no longer treat the client as fully stopped while a websocket task may already exist or start is in progress.STOPPED_BITis set again if task creation fails, restoring the initialized “stopped” state sostop()/destroy()do not block forever waiting for a task that never started.Reviewed by Cursor Bugbot for commit b2b86d7. Bugbot is set up for automated code reviews on this repo. Configure here.