Skip to content

[modem]: Additional hardening (uart/netif) #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-cermak merged 2 commits into from
May 6, 2026
Merged

[modem]: Additional hardening (uart/netif) #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be5f6a
fix(modem): Fix netif destructor UAF
david-cermak Feb 23, 2026
9176fa6
fix(modem): Prevent UART read -1/int leak to size_t
david-cermak May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/esp_modem/src/esp_modem_netif.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ void Netif::pause()

Netif::~Netif()
{
ppp_dte->set_read_cb(nullptr);
if (signal.is_any(PPP_STARTED)) {
esp_netif_action_stop(driver.base.netif, nullptr, 0, nullptr);
signal.clear(PPP_STARTED);
Expand Down
4 changes: 4 additions & 0 deletions components/esp_modem/src/esp_modem_uart.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ int UartTerminal::read(uint8_t *data, size_t len)
length = std::min(len, length);
if (length > 0) {
int read_len = uart_read_bytes(uart.port, data, length, portMAX_DELAY);
if (read_len < 0) {
ESP_LOGE(TAG, "Error occurred during read: %d", read_len);
return 0;
}
#if CONFIG_ESP_MODEM_ADD_DEBUG_LOGS
ESP_LOG_BUFFER_HEXDUMP("uart-rx", data, read_len, ESP_LOG_DEBUG);
#endif
Expand Down
Loading