Allow extra HTTP headers in BOSH and WebSockets.#2772
Closed
varnerac wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @varnerac, thanks for the patch. There are appetite and need for the CORS headers, there is even another PR #1195 where the headers are always added in case of BOSH connection. I think making them configurable would be a more flexible solution. When it comes to your changes, they don't integrate well with cowboy yet. All the tests connecting users over BOSH or WS failed. You can try it locally by running the following commands: tools/test-runner.sh --skip-small-tests --skip-cover --preset internal_mnesia -- wsor tools/test-runner.sh --skip-small-tests --skip-cover --preset internal_mnesia -- boshMore on the |
Contributor
Author
|
I'll tackle this in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR
Proposed changes include:
This isn't ready yet. I just wanted to test the waters and see if you had an appetite for a patch like this. We want the ability to add CORS headers and security headers like HSTS to the BOSH and WebSockets endpoints.