need to use collections.abc.Sequence instead of collections.Sequence in python 3.10 and later - #33
Open
lucasw wants to merge 2 commits into
Open
need to use collections.abc.Sequence instead of collections.Sequence in python 3.10 and later#33lucasw wants to merge 2 commits into
lucasw wants to merge 2 commits into
Conversation
lucasw
added a commit
to lucasw/ros_from_src
that referenced
this pull request
Jan 8, 2023
|
could you also make your pr at https://github.com/ros-o/ros_numpy? |
Author
|
It's already in obese-devel on the ros-o fork @lianghongzhuo (maybe only as of this morning) - I'll leave this open here in case it comes back under maintenance but anyone else with an issue or pr should be pointed at ros-o Back linking to ros-o/ros-o#7 (reply in thread) |
|
Thank you! |
eric-wieser
reviewed
Nov 3, 2023
eric-wieser
left a comment
eric-wieser
left a comment
Owner
There was a problem hiding this comment.
Strictly this breaks Python 2; I think probably support for python2 should be removed from the package.xml at the same time as this change.
lucasw
force-pushed
the
collections_abc
branch
from
November 3, 2023 14:45
e061443 to
16eb25b
Compare
Author
Rebased and removed the python 2 from package.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(added another commit here to solve the np.float issue #32 but can remove it)