ENH: Add original I,J,K as properties in NestedHybridGrid - #492
Conversation
|
# Conflicts: # src/fmu/tools/nestedhybridgrid/nestedhybrid.py
499b863 to
db7e53a
Compare
alifbe
left a comment
There was a problem hiding this comment.
These properties is very useful for mapping between nested grid and parent grid which is hopefully can be fully automated from within NHG class. So, at least for now, we don't see the needs for this property to be exported to RMS. Please ensure that .to_rms() method doesn't export these IJK properties.
450eed8 to
524b5a7
Compare
|
Implemented:
|
tnatt
left a comment
There was a problem hiding this comment.
This looks good to me 🙂
We might want to add some info regarding these properties into the documentation, to inform they are there.. but we can maybe wait and see if the need arises. If there is a need, the best solution would perhaps be to add a flag in the to_rms function to easily store these properties in rms.
alifbe
left a comment
There was a problem hiding this comment.
Looks great. Please consider changing the commit message. For some case where user do nested over nested, original could be interpreted as origin grid. But in this case, the property that is created is direct parent.
Resolves #470
Adds preservation of original grid I/J/K coordinates for
NestedHybridGrid._build_nested_hybrid_grid()now appendsI_orig, J_orig, andK_origproperties to the coarse grid before refinement and merge, allowingxtgeo.grid_merge()to transfer them automatically to the final nested hybrid grid. These properties are available throughnhg.propertiesandnhg.grid.get_prop_by_name(...).Also updates the nested hybrid grid property test to verify the new properties are present and retain the original 1-based coordinates.
Checklist
--cov=src/ --cov-report term-missing)