DOC : Update HOOK_WORKFLOW_JOB documentation - #1877
Open
nourinmohd wants to merge 1 commit into
Open
nourinmohd wants to merge 1 commit into
nourinmohd wants to merge 1 commit into
Conversation
GibranAlfa
removed their request for review
October 5, 2026 08:22
tnatt
approved these changes
Oct 5, 2026
tnatt
left a comment
tnatt
left a comment
Collaborator
There was a problem hiding this comment.
Nice change 🙂 one suggestion added below
Comment on lines
+103
to
+104
| The `"--sumo"` argument is optional. When it is included, `<SUMO_CASEPATH>` | ||
| must be defined in the ERT config. |
Collaborator
There was a problem hiding this comment.
Suggest adding a typical example of how to define the casepath. Also lets make it more clear that we want people to use Sumo 🙂
Suggested change
| The `"--sumo"` argument is optional. When it is included, `<SUMO_CASEPATH>` | |
| must be defined in the ERT config. | |
| The `"--sumo"` argument is recommended and is used to register the case in Sumo. If specified, `<SUMO_CASEPATH>` must be defined in the ERT config, for example: | |
| DEFINE <SUMO_CASEPATH> <SCRATCH>/<USER>/<CASE_DIR> |
| case metadata are used to register the case. Case metadata are made by a | ||
| hooked (pre-sim) Ert workflow running `PRE_SIMULATION`. | ||
|
|
||
| To make this, first create the workflow file in |
Collaborator
There was a problem hiding this comment.
Love the look of all this red 🔴
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1816
Updated
getting_started.mdto:HOOK_WORKFLOW_JOBdirectly.WF_CREATE_CASE_METADATA "--sumo"form.Checklist
--cov=src/ --cov-report term-missing)