Repository navigation
MAINT: Consolidate workflow logic - #1859
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
+ Coverage 97.67% 97.95% +0.27%
==========================================
Files 59 60 +1
Lines 3748 3721 -27
==========================================
- Hits 3661 3645 -16
+ Misses 87 76 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tnatt
force-pushed
the
consolidate-workflow-logic
branch
4 times, most recently
from
September 23, 2026 07:50
2aad6ed to
5eae4c8
Compare
tnatt
marked this pull request as ready for review
September 23, 2026 07:55
tnatt
commented
Sep 29, 2026
| """ # noqa | ||
|
|
||
|
|
||
| def main() -> None: |
Collaborator
Author
There was a problem hiding this comment.
This main function seems like legacy. Most likely remnants from before we converted to the new ERT workflow plugin system.
tnatt
commented
Sep 29, 2026
| casepath = _resolve_casepath(run_paths, args.ert_caseroot) | ||
| ert_config_path = _resolve_ert_config_path(run_paths, args.ert_config_path) | ||
| casepath = resolve_casepath(run_paths, args.ert_caseroot) | ||
| ert_config_path = Path(run_paths.substitutions["<CONFIG_PATH>"]) |
Collaborator
Author
There was a problem hiding this comment.
The ert config path is always set by ert in the substitutions. So this should be enough 🙂
tnatt
commented
Sep 29, 2026
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
nourinmohd
approved these changes
Sep 29, 2026
nourinmohd
left a comment
nourinmohd
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 from my understanding
tnatt
force-pushed
the
consolidate-workflow-logic
branch
from
October 2, 2026 12:45
5eae4c8 to
bacf85f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1858
Checklist
--cov=src/ --cov-report term-missing)