Conversation
The two-phase mark/sweep in cacheClean() was broken: garbage flag was set unconditionally before the mark test, making the mark branch dead code. Every idle channel was swept immediately with no grace period, causing constant channel rebuild churn under polling workloads. Move garbage=true into the mark branch so idle channels are marked on one tick and swept only if still idle on the next. This restores the intended grace period where Channel::build() can reset the flag. Also compact chanByCID during cacheClean to remove expired weak_ptr entries left by destroyed channels, preventing unbounded map growth. Add testgc to verify mark/sweep, channel reuse, and disconnect behavior.
The connect() op may fire an initial onDisconnect before onConnect. Use a polling loop on the current-state flag (matching testget.cpp pattern) and compare disconnect counts relative to a snapshot instead of assuming zero.
Verify channel presence/absence in cache via report() around mark/sweep, and confirm channel reuse by asserting single channel count and growing tx bytes across consecutive gets.
bisegni
marked this pull request as ready for review
September 11, 2026 19:22
Member
Contributor
Author
|
great thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues in the client channel cache garbage collection:
Tests (testgc.cpp):