Fixes for issues triggered by Windows CI

src/ca/caProvider.cpp

@@ -134,6 +134,12 @@ void CAClientFactory::start()
 
 void CAClientFactory::stop()
 {
+    // Deregister the provider. Does nothing if no "ca" provider is registered.
+    // Any CAChannelProvider instances already handed out stay alive until their
+    // references are released.
+    //
+    // Important on Windows where exit handlers are not run when main() returns.
+    ChannelProviderRegistry::clients()->remove("ca");
 }
 
 }}}

src/ca/pv/caProvider.h

@@ -38,11 +38,14 @@ class epicsShareClass CAClientFactory
 public:
     /** @brief start provider ca
      *
+     * Registers the ca provider with the client registry.
      */
     static void start();
     /** @brief stop provider ca
      *
-     * This does nothing.
+     * Unregisters the ca provider from the client registry, undoing start().
+     * Any CAChannelProvider instance already handed out stays alive until its
+     * owners release it.
      */
     static void stop();
 };

src/server/responseHandlers.cpp

@@ -1460,6 +1460,9 @@ void ServerChannelPutRequesterImpl::send(ByteBuffer* buffer, TransportSendContro
         _status.serialize(buffer, control);
     }
 
+    // Call stopRequest() before serializing the payload
+    stopRequest();
+
     if (_status.isSuccess())
     {
         if ((QOS_INIT & request) != 0)
@@ -1475,8 +1478,6 @@ void ServerChannelPutRequesterImpl::send(ByteBuffer* buffer, TransportSendContro
         }
     }
 
-    stopRequest();
-
     // lastRequest
     if ((QOS_DESTROY & request) != 0)
         destroy();
@@ -1729,6 +1730,9 @@ void ServerChannelPutGetRequesterImpl::send(ByteBuffer* buffer, TransportSendCon
         _status.serialize(buffer, control);
     }
 
+    // Call stopRequest() before serializing the payload.
+    stopRequest();
+
     if (_status.isSuccess())
     {
         if ((QOS_INIT & request) != 0)
@@ -1759,8 +1763,6 @@ void ServerChannelPutGetRequesterImpl::send(ByteBuffer* buffer, TransportSendCon
         }
     }
 
-    stopRequest();
-
     // lastRequest
     if ((QOS_DESTROY & request) != 0)
         destroy();
@@ -2365,6 +2367,9 @@ void ServerChannelArrayRequesterImpl::send(ByteBuffer* buffer, TransportSendCont
         _status.serialize(buffer, control);
     }
 
+    // Call stopRequest() before serializing the payload.
+    stopRequest();
+
     if (_status.isSuccess())
     {
         if ((QOS_GET & request) != 0)
@@ -2385,8 +2390,6 @@ void ServerChannelArrayRequesterImpl::send(ByteBuffer* buffer, TransportSendCont
         }
     }
 
-    stopRequest();
-
     // lastRequest
     if ((QOS_DESTROY & request) != 0)
         destroy();