When an item is selected in ExpandableDataPickerSample, it falls into… - #2953
Open
Sangwook-Lee wants to merge 1 commit into
Open
When an item is selected in ExpandableDataPickerSample, it falls into…#2953Sangwook-Lee wants to merge 1 commit into
Sangwook-Lee wants to merge 1 commit into
Conversation
… an infinite loop. So, application is stopped. Modified activateChanged handler is called when this.active is equeal to `true`. Changed tap event handler of SelectableItem to be called when both 'selected' and 'active' are equal to `true`. ENYO-4657 Enyo: when an item is selected in ExpandableDataPicker, it falls into an infinite loop Enyo-DCO-1.1-Signed-off-by: Sangwook Lee sangwook1203.lee@lge.com
Sangwook-Lee
changed the base branch from
release-2.6.4-rc.16
to
release-2.6.4-rc.17
September 18, 2017 05:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When an item is selected in ExpandableDataPickerSample, it falls into an infinite loop.
So, application is stopped.
Fix
Modified activateChanged handler is called when this.active is equeal to
true.Changed tap event handler of SelectableItem to be called when both 'selected' and 'active' are equal to
true.ENYO-4657 Enyo: when an item is selected in ExpandableDataPicker, it falls into an infinite loop
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee sangwook1203.lee@lge.com