dynamic_modules: expose current log level getter#46052
Merged
Merged
Conversation
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
reviewed
Jul 9, 2026
| @@ -495,6 +495,15 @@ void envoy_dynamic_module_callback_log(envoy_dynamic_module_type_log_level level | |||
| */ | |||
| bool envoy_dynamic_module_callback_log_enabled(envoy_dynamic_module_type_log_level level); | |||
Member
There was a problem hiding this comment.
should we deprecate envoy_dynamic_module_callback_log_enabled?
Member
Author
There was a problem hiding this comment.
Yes, I can do a follow-up to deprecate it
mathetake
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
envoy_dynamic_module_callback_get_log_levelABI callback and surfaces it in the Rust and Go SDKs so modules can read the effective log level and gate expensive work.Fixes #45032
Commit Message: dynamic_modules: expose current log level getter
Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: Added