Adds In-Memory Peer Metadata Exchange In Istio PMX Filters#46045
Open
grnmeira wants to merge 2 commits into
Open
Adds In-Memory Peer Metadata Exchange In Istio PMX Filters#46045grnmeira wants to merge 2 commits into
grnmeira wants to merge 2 commits into
Conversation
Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds In-Memory Peer Metadata Exchange In Istio PMX Filters
Additional Description:
Istio uses network filters to communicate upstream peer information in the downstream direction. That's done because of current Envoy restrictions on filter state flow direction, that being only allowed in the upstream direction.
Give that constraint, the first PMX baggage filters used in Istio Ambient scenarios implemented this upstream -> downstream communication injecting information in the stream data itself. That worked because usually the two filters trying to communicate sit between a raw internal socket (io_stream_handler). Though, for cases where that socket incorporates TLS or PROXY protocol encoding/decoding, that becomes a problem as the injected data breaks encoding/decoding process.
This PR introduces that information exchange "out of the wire", using a combination between filter state and Envoy's thread local storage system.
It works like this:
Risk Level: Low, as it's isolated to Istio contrib filters
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]