cache: fix cyclic ABSL_ACQUIRED_BEFORE annotations in CacheEvictionThread#46043
Merged
Merged
Conversation
…read The two mutexes mu_ and cache_mu_ are never held simultaneously, so no lock ordering annotation is needed. The previous circular ACQUIRED_BEFORE hack (each pointing to the other) is rejected by clang 22's improved -Wthread-safety-analysis. Remove the ordering annotations; the GUARDED_BY annotations on the protected fields remain and are sufficient. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
ravenblackx
approved these changes
Jul 9, 2026
ravenblackx
left a comment
ravenblackx
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Shame there's still no "not acquired together" annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two mutexes mu_ and cache_mu_ are never held simultaneously, so no lock ordering annotation is needed. The previous circular
ACQUIRED_BEFOREhack (each pointing to the other) is rejected by clang 22's improved-Wthread-safety-analysis.Remove the ordering annotations; the
GUARDED_BYannotations on the protected fields remain and are sufficient.