Skip to content

Add HCA-aware Registrars and Reverse Adapters #367

Closed
adraffy wants to merge 2 commits into
feat/verifiable-reverse-adaptersfrom
feat/verifiable-reverse-adapters-with-context
Closed

Add HCA-aware Registrars and Reverse Adapters #367
adraffy wants to merge 2 commits into
feat/verifiable-reverse-adaptersfrom
feat/verifiable-reverse-adapters-with-context

Conversation

@adraffy

@adraffy adraffy commented Jul 10, 2026

Copy link
Copy Markdown
Member
  • changed HCAAuthorizer to HCAContext
    • moved trustedImplementations[] to a PermissionedAddressSet
    • restored _msgSender()-like functionality as _unwrapSender()
  • removed *withHCA()-functions from adapters
    • use _unwrapSender() instead
  • added HCAContext to registrars
    • SafeERC20 uses _unwrapSender() instead of msg.sender
      • calls from trusted HCA transfer from EOA

  • add address payer to NameRegistered and NameRenewed
  • add tests for registrars with HCA

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (post-audit-2@a83dc5b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             post-audit-2     #367   +/-   ##
===============================================
  Coverage                ?   99.92%           
===============================================
  Files                   ?       51           
  Lines                   ?     2732           
  Branches                ?        0           
===============================================
  Hits                    ?     2730           
  Misses                  ?        2           
  Partials                ?        0           
Flag Coverage Δ
DNSTLDResolver 87.22% <0.00%> (?)
ENSV1Resolver 87.22% <0.00%> (?)
ENSV2Resolver 87.22% <0.00%> (?)
L2ReverseRegistrar 87.22% <0.00%> (?)
LibISO8601 87.22% <0.00%> (?)
deployV2Fixture 87.22% <0.00%> (?)
forge 90.94% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/registrar/AbstractETHRegistrar.sol 100.00% <100.00%> (ø)
contracts/src/registrar/ETHRegistrar.sol 100.00% <100.00%> (ø)
contracts/src/registrar/ETHRenewerV1.sol 100.00% <ø> (ø)
...verse-registrar/DefaultReverseRegistrarAdapter.sol 100.00% <100.00%> (ø)
.../src/reverse-registrar/ReverseRegistrarAdapter.sol 100.00% <100.00%> (ø)
...rc/reverse-registrar/libraries/AccountNamerLib.sol 100.00% <ø> (ø)
contracts/src/utils/HCAContext.sol 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adraffy
adraffy changed the base branch from post-audit-2 to feat/verifiable-reverse-adapters July 10, 2026 15:21
@makoto

makoto commented Jul 13, 2026

Copy link
Copy Markdown
Member

Am I correct to understand this PR is not necessary? @adraffy @TateB ?

@adraffy

adraffy commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

It was an option, but not needed if HCA will hold assets.

@makoto

makoto commented Jul 20, 2026

Copy link
Copy Markdown
Member

Shall we close ?

@adraffy

adraffy commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Yeah, I copied the adapter parts to #373

@adraffy adraffy closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants