fix(indexer): redact provider endpoint URLs in transport-error logs#178
Merged
Conversation
Render reqwest URLs as scheme and host at every provider warning sink, and sanitize owned transport errors before they reach higher-level loggers. Preserve reqwest error types and retry classification, with timeout regressions covering retry warnings and exhaustion. Fixes #176. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C9RTnbCyhqEUSPc7xCK76p
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176. Provider endpoint URLs carry API keys in the path; transport-error logging rendered them unredacted at multiple WARN sinks (one added by #175, the retry WARNs pre-existing) — plus, found during the verify-loop, a terminal retry-exhaustion Debug sink leaking the propagated error's URL.
A shared redaction helper (apps/indexer/src/provider/error.rs) renders reqwest/anyhow transport errors with the URL reduced to scheme+host; all provider WARN sites (retry, pool-rebuild, block-transaction, receipt-fallback) go through it, and propagated errors are sanitized without changing their type or retry classification (regression test proves a redacted timeout still classifies retryable; a failing test reproduced the Debug-sink leak before the fix).
Authored by codex (packet + $verify-loop: first reviewer found the Debug-sink leak, second reviewer clean). Gates: fmt/clippy clean, size ratchet OK, indexer suite 477 passed.
Operational note (issue #176): the key already appears in weeks of host-local logs; rotation is recommended independent of this fix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01C9RTnbCyhqEUSPc7xCK76p