msp430: some cleanup to i2c code - #582
Open
alfh wants to merge 4 commits into
Open
Conversation
Replace #ifdef with #if defined, to consistently use if defined in the twi.c file. Likewise, replace ifndef with if !defined.
alfh
force-pushed
the
feature_i2c_cleanup
branch
from
March 29, 2015 08:24
4163571 to
19b3074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code cleanup of the msp430 i2c code, in preparation of more work for adding support for choosing which USCB port to use, and also to be able to use more than one USCB port.
I am a bit unsure if my changes from ifdef to if defined is something you like, please comment if you do not like it.