Skip to content

fix(daemon): bump better-sqlite3 to ^12 and unpin Node 24 in CI #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumavis merged 3 commits into from
Sep 1, 2026
Merged

fix(daemon): bump better-sqlite3 to ^12 and unpin Node 24 in CI #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5844a27
fix(daemon): bump better-sqlite3 to ^12 for Node 24 teardown abort
claude Aug 13, 2026
98312e3
fix(ci): unpin Node 24 now that better-sqlite3 12 survives teardown
claude Sep 1, 2026
e728a1d
chore: Update yarn.lock
claude Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Temporarily pin Node 24: Node 24.19 triggers the better-sqlite3@11.10.0
# legacy node::ObjectWrap cleanup abort; see
# https://github.com/nodejs/node/pull/65042.
node-version: [22.x, 24.18.0]
node-version: [22.x, 24.x]
platform: [ubuntu-latest, macos-15]
# windows-latest exhibited flakey tests that are not yet worth the
# trouble to investigate, and blocked us from upgrading yarn from 1 to
Expand Down Expand Up @@ -332,10 +329,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Temporarily pin Node 24: Node 24.19 triggers the better-sqlite3@11.10.0
# legacy node::ObjectWrap cleanup abort; see
# https://github.com/nodejs/node/pull/65042.
node-version: [22.x, 24.18.0]
node-version: [22.x, 24.x]
platform: [ubuntu-latest]

steps:
Expand Down Expand Up @@ -377,10 +371,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Temporarily pin Node 24: Node 24.19 triggers the better-sqlite3@11.10.0
# legacy node::ObjectWrap cleanup abort; see
# https://github.com/nodejs/node/pull/65042.
node-version: [22.x, 24.18.0]
node-version: [22.x, 24.x]
platform: [ubuntu-latest]

steps:
Expand Down Expand Up @@ -486,10 +477,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Temporarily pin Node 24: Node 24.19 triggers the better-sqlite3@11.10.0
# legacy node::ObjectWrap cleanup abort; see
# https://github.com/nodejs/node/pull/65042.
node-version: [22.x, 24.18.0]
node-version: [22.x, 24.x]
platform: [ubuntu-latest]

steps:
Expand Down
2 changes: 1 addition & 1 deletion packages/daemon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@endo/utf8": "workspace:^",
"@endo/where": "workspace:^",
"@endo/zip": "workspace:^",
"better-sqlite3": "^11.0.0",
"better-sqlite3": "^12.0.0",
"ses": "workspace:^",
"ws": "^8.21.3"
},
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,7 @@ __metadata:
"@number0/iroh": "npm:^1.1.0"
"@types/ws": "npm:^8.18.1"
ava: "catalog:dev"
better-sqlite3: "npm:^11.0.0"
better-sqlite3: "npm:^12.0.0"
c8: "catalog:dev"
eslint: "catalog:dev"
expect-type: "npm:^1.4.0"
Expand Down Expand Up @@ -7942,14 +7942,14 @@ __metadata:
languageName: node
linkType: hard

"better-sqlite3@npm:^11.0.0":
version: 11.10.0
resolution: "better-sqlite3@npm:11.10.0"
"better-sqlite3@npm:^12.0.0":
version: 12.11.1
resolution: "better-sqlite3@npm:12.11.1"
dependencies:
bindings: "npm:^1.5.0"
node-gyp: "npm:latest"
prebuild-install: "npm:^7.1.1"
checksum: 10c0/1fffbf9e5fc9d24847a3ecf09491bceab1c294b46ba41df1c449dc20b6f5c5d9d94ff24becd0b1632ee282bd21278b7fea53a5a6215bb99209ded0ae05eda3b0
checksum: 10c0/162d3fa6c19a68191d09537bd113bd54a636c9fb38b0fc0796f4f270032770695ef35a1bca041a0a0fa9bfa47e20b9e17c94484a3899c31f38881af4d12b7fa5
languageName: node
linkType: hard

Expand Down
Loading