[sdl] Remove obsolete mozAudioChannelType workaround#27340
Merged
Conversation
dschuff
approved these changes
Jul 14, 2026
Remove references to `mozAudioChannelType` from `Mix_LoadWAV` and `Mix_QuickLoad_RAW` in `libsdl.js`. This workaround (`audio.mozAudioChannelType = 'content'`) was added in 2014 (commit f0d1529) for Boot to Gecko (B2G) / Firefox OS games so that audio on the `content` channel would behave correctly when the screen turned off or the app went to the background. This is safe to remove because: 1. Firefox OS / B2G was discontinued (~2016) and moved to the Firefox OS Graveyard. 2. The `AudioChannel` API and `mozAudioChannelType` property were removed from Gecko (`mozilla-central`). Setting `mozAudioChannelType` has no effect on Firefox desktop or any modern browser. 3. Bugzilla bug #910340 (`When screen is switched off, visibilitychange is not firing when audio is playing`) was closed in 2014 as `RESOLVED WONTFIX` since continuing audio playback when the screen turns off is expected mobile behavior. See: https://bugzilla.mozilla.org/show_bug.cgi?id=910340
sbc100
force-pushed
the
remove-mozaudiochanneltype
branch
from
e8ff4f0 to
d0ed7cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to
mozAudioChannelTypefromMix_LoadWAVandMix_QuickLoad_RAWinlibsdl.js.This workaround (
audio.mozAudioChannelType = 'content') was added in 2014 (commit f0d1529) for Boot to Gecko (B2G) / Firefox OS games so that audio on thecontentchannel would behave correctly when the screen turned off or the app went to the background.This is safe to remove because:
AudioChannelAPI andmozAudioChannelTypeproperty were removed from Gecko (mozilla-central). SettingmozAudioChannelTypehas no effect on Firefox desktop or any modern browser.When screen is switched off, visibilitychange is not firing when audio is playing) was closed in 2014 asRESOLVED WONTFIXsince continuing audio playback when the screen turns off is expected mobile behavior.See: https://bugzilla.mozilla.org/show_bug.cgi?id=910340