feat: center dimensions and add independent text color flag (-t) - #199
Open
2004sfm wants to merge 5 commits into
Open
feat: center dimensions and add independent text color flag (-t)#1992004sfm wants to merge 5 commits into
2004sfm wants to merge 5 commits into
Conversation
This commit introduces two improvements for the dimensions display (-d): 1. Centers the dimensions text within the selection box using cairo_text_extents to prevent the text from being cut off at screen edges. 2. Introduces a new '-t' flag to allow setting an independent color for the dimensions text, falling back to the border color if not provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When using -d , the text is drawn with a fixed offset outside the selection box, causing it to be cut off if the selection hits the right or bottom edges of the screen. Furthermore, it inherits the border color, which can cause contrast issues.
Solution: