Skip to content

fix(cbh,osint): four terminal-tooling bugs — triage gate, report BOM/CRLF, Windows console, h1 --program - #210

Merged
elementalsouls merged 6 commits into
mainfrom
fix/tooling-bugfixes
Nov 22, 2026
Merged

elementalsouls merged 6 commits into
mainfrom
fix/tooling-bugfixes

Conversation

@elementalsouls

Copy link
Copy Markdown
Owner

Four genuine bugs in the terminal tooling, each independently reported on a fork PR, built in-house with TDD and reporter credit (per the project's "own the code, credit the reporters" approach) rather than merging the forks.

Fixes

cbh triage 7-Question Gate — three false-verdict paths

cbh report dropped frontmatter behind a UTF-8 BOM / CRLF

A BOM (and Windows CRLF) before the --- fence pushed it off the ^--- anchor, so severity/asset fell back to defaults. parse_finding_metadata now normalizes both at the shared chokepoint every command reads through. Reported by @jazzpher (#200).

cbh / setup_harness_mcp.py crashed on non-UTF-8 Windows consoles

The gate glyphs (✓/✗/→/—) raised UnicodeEncodeError under cp1252. Both entrypoints reconfigure stdout/stderr to UTF-8, matching engine/engine.py. Reported by @Sahilkumar-r (#180).

h1_reference.py --program returned nothing

CompleteHacktivityReportIndex no longer accepts terms: {team_id: ...}. Switched to query_string: "team_handle:<handle>", which filters correctly and composes with --top-voted/--top-bounty; the lookup now resolves the canonical handle (query_string is case-sensitive, TeamLookup is not) and progress moved to stderr so --json stdout stays pipeable. Two independent reports converged here: @roonnnnyyyyyy (#206) and @flipcyde101 (#202).

Testing

  • tests/: 83 OK · engine/: 35 OK · scan_identifiers: 0 · check_doc_counts: 0 · .ps1 ASCII-only.
  • Every fix went RED→GREEN; a fresh adversarial review of the branch caught five follow-up defects (all fixed, TDD'd).

Reviewer note — needs a live check

The --program query_string form is live-tested by both source-PR authors but could not be verified against the live H1 API from this environment. Please confirm --program against live H1 before relying on it. The other three fixes are fully covered offline.

Supersedes / credits

Built in-house in place of merging: #209, #197, #200, #180, #206, #202. Each source PR will be closed with thanks + the merge SHA once this lands.

🤖 Generated with Claude Code

elementalsouls and others added 6 commits November 22, 2026 16:52
…r Q3, clickjacking for Q7

Three false-verdict paths in the 7-Question Gate, each independently reported:

- Q1 matched a bare method word anywhere in the text, so prose like
  "target application" (contains "get ") or "input validation" passed Q1
  with no request at all. Q1 now needs a method followed by a path or URL
  (or curl / HTTP/1.1). Reported by @dajiaohuang (#209).
- Q7's never-submit list had "click-jacking" but not "clickjacking", so the
  unhyphenated spelling was never killed. Reported by @Ethereal49 (#197).
- Q3 answered YES on any scope/asset wording even when the finding itself
  said "out of scope" / "unverified". A scope/asset line carrying a negation
  no longer counts as in-scope evidence; non-scope lines ("Impact: unclear")
  still don't. Reported by @Ethereal49 (#197).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A BOM (\ufeff) written by some Windows editors sits before the `---` fence,
so the `^---` frontmatter regex missed it and severity/asset fell back to
defaults. Strip a leading BOM in parse_finding_metadata, the shared chokepoint
for every command that reads a finding, not just `cbh report`.

Reported by @jazzpher (#200).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cbh and setup_harness_mcp.py print the gate glyphs (check / cross / arrow /
em-dash) throughout. On a Windows console (cp1252) a bare print() raised
UnicodeEncodeError and the command died mid-run. Reconfigure stdout/stderr to
UTF-8 at both entrypoints, the same fix engine/engine.py:main already uses, so
the whole CLI is covered at one point rather than guarding every print.

Reported by @Sahilkumar-r (#180).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ot team_id

CompleteHacktivityReportIndex no longer accepts terms: {team_id: ...}, so
--program silently returned nothing. Switch to query_string "team_handle:<h>",
which filters correctly and still accepts sort + pagination (so --program now
composes with --top-voted / --top-bounty). Also: route the lookup progress line
to stderr so --json stdout stays pipeable, and reject an empty --program handle.

Two independent reports converged on this fix: @roonnnnyyyyyy (#206) and
@flipcyde101 (#202).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…anonical handle

Adversarial review of the branch surfaced five real defects:

- Q3 _q3_scope_negated matched ANY line containing 'scope' plus a negation,
  so 'Impact: unclear scope of data exposure' wrongly killed an in-scope
  finding. Negation is now evaluated per line: strong phrases ('out of scope')
  disavow anywhere; weak words ('unknown','unclear') only on a scope/asset/
  target line (the key before the colon).
- Q3 negation list was space-only, so the common hyphenated 'out-of-scope'
  slipped through. Hyphens are normalized to spaces before matching.
- Q1 required whitespace between method and path, missing the markdown a PoC
  is usually written in (`GET /x`, **GET** /x, GET `/x`). The separator class
  now allows backticks and bold/italic markers. The prose ceiling
  ('an attacker can get /admin') is marked, not closed — requiring HTTP/ would
  reject the bare 'GET /path' PoC the gate must accept.
- parse_finding_metadata now also normalizes CRLF, so Windows findings (the
  same platform as the BOM in #200) don't skip frontmatter.
- h1_reference --program queried the raw input handle; query_string is
  case-sensitive while TeamLookup is not, so '--program Shopify' could return
  nothing. lookup_program now returns the team record and main uses the
  canonical handle.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant