Repository navigation
fix(scope): stop out-of-scope rules from silently failing open #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fairoz-539
wants to merge
2
commits into
elementalsouls:main
Choose a base branch
from
fairoz-539:fix/scope-deny-rules-fail-open
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+270
−35
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Audit Bench Ai (automated) | 🧠 Logic | 🟠 High
Subnet masks in URL-formatted rules are stripped into single host IPs
When an IP CIDR block is supplied in URL format (such as
http://10.0.0.0/24or10.0.0.0/24),_canonical_ip(t)on line 71 handles bare CIDRs like10.0.0.0/24. However, if the rule has a scheme likehttp://10.0.0.0/24or extra URL components, it bypasses_canonical_ip(t)and is parsed viaurlparse('//' + t). In that case,urlparsetreats/24asparsed.pathandparsed.hostnamebecomes just10.0.0.0. The rule is normalized to the single IP10.0.0.0, discarding the/24subnet entirely and leaving the rest of the subnet unprotected by out-of-scope deny rules.Why it happens:
urlparsesplits the CIDR prefix into the path component when parsing URLs containing CIDRs, and_normalize_ruleassignshost = parsed.hostname.When it breaks: An out-of-scope rule is entered as
https://192.168.1.0/24. Normalization reduces the rule to192.168.1.0. A target at192.168.1.5is checked; it does not match192.168.1.0, bypassing the out-of-scope restriction entirely.Tests: Test
test_regex_and_cidr_rules_are_untouchedonly tests bare CIDRs like2001:db8::/32, not CIDRs entered with a scheme or URL prefix.Suggested fix: Before parsing with
urlparse, check if the host component contains an IP network CIDR, or re-attach the path if the host is an IP address andparsed.pathstarts with a valid network prefix length.95% confidence · 💬 Reply here and Audit Bench Ai will recheck the code · 👀 to acknowledge · 👍/👎 teaches it what your team wants