Skip to content

Update jackson to 2.21.6 - #19442

Open
donoghuc wants to merge 2 commits into
elastic:mainfrom
donoghuc:bump-jackson-26
Open

Update jackson to 2.21.6#19442
donoghuc wants to merge 2 commits into
elastic:mainfrom
donoghuc:bump-jackson-26

Conversation

@donoghuc

Copy link
Copy Markdown
Member

Release notes

Update jackson to 2.21.6

What does this PR do?

Get the latests 2.21 LTS for jackson in logstash core.

Relates: #19440

Copilot AI lite review requested due to automatic review settings August 19, 2026 20:16
@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Logstash core’s Jackson dependencies to the latest 2.21 LTS patch release and adjusts the repository’s notice text for the affected Jackson artifacts.

Changes:

  • Bump jackson and jackson-databind from 2.21.4 to 2.21.6, and bump jrjackson from 0.5.2 to 0.5.3 in versions.yml.
  • Update NOTICE.TXT entries for Jackson artifacts to reflect 2.21.6.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
versions.yml Updates the single source-of-truth versions for Jackson and JrJackson used by core build/gemspec wiring.
NOTICE.TXT Updates notice headers for Jackson components to match the new 2.21.6 versions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread versions.yml
Comment on lines +30 to +32
jrjackson: 0.5.3
jackson: 2.21.6
jackson-databind: 2.21.6
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

Buildkite failures are caused by dependency resolution during :bootstrap, not by test logic. This PR pins jrjackson to 0.5.3, but that gem version is not published on RubyGems, so all Ruby-backed test jobs fail before tests start.

Remediation

  • Change jrjackson in versions.yml back to an available version (currently 0.5.2) or publish jrjackson 0.5.3 before merging this PR.
  • Re-run the Buildkite pipeline after the dependency pin is corrected; :bootstrap must complete before unit/integration jobs can execute.
Investigation details

Root Cause

logstash-core hard-pins jrjackson from versions.yml in its gemspec (logstash-core/logstash-core.gemspec:79).
In this PR head, versions.yml sets jrjackson: 0.5.3 (versions.yml:30 on 1a2a188).
During Buildkite bootstrap, Bundler solver fails because jrjackson 0.5.3 is unavailable, so jobs abort before running test suites.

Evidence

Execution failed for task ':bootstrap'.
> (SolveFailure) Could not find compatible versions
  Because every version of logstash-core depends on jrjackson = 0.5.3
  and jrjackson = 0.5.3 could not be found in rubygems repository https://rubygems.org/ or installed locally,
  logstash-core cannot be used.
  • Log references:
    • /tmp/gh-aw/buildkite-logs/logstash-pull-request-pipeline-rspec-ruby-unit-tests.txt:75-89
    • /tmp/gh-aw/buildkite-logs/logstash-pull-request-pipeline-lab_coat-integration-tests-part-1-of-6.txt:95-109
    • /tmp/gh-aw/buildkite-logs/logstash-pull-request-pipeline-lab_coat-x-pack-unit-tests.txt:101-115

Verification

  • Confirmed PR diff updates versions.yml to jrjackson: 0.5.3.
  • Confirmed Rubygems versions list for jrjackson does not include 0.5.3 (latest visible: 0.5.2).

Follow-up

If the intent is to consume newer Jackson artifacts, keep Jackson updates but align to a released jrjackson version (or release the required jrjackson first).


What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@yaauie yaauie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted by copilot, the notice for jrJackson will need to be updated. Other than that, LGTM.

Copilot AI review requested due to automatic review settings August 19, 2026 23:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

NOTICE.TXT:3931

  • NOTICE.TXT appears to be generated by the dependencies audit tool from per-dependency notice templates (see tools/dependencies-report/README.md:9-11). This PR updates the jrjackson notice here to v0.5.3, but the source template tools/dependencies-report/src/main/resources/notices/jrjackson-NOTICE.txt still points to v0.4.6, so regenerating NOTICE.TXT would revert this change.
Notice for: jrjackson-0.5.3
----------

https://github.com/guyboertje/jrjackson/blob/v0.5.3/README.md

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Aug 19, 2026

Copy link
Copy Markdown

⏳ Build in-progress, with failures

Failed CI Steps

History

@andsel andsel mentioned this pull request Aug 20, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants