Repository navigation
Add stylelint and eslint with working configs - #378
Merged
Merged
Conversation
eirvandelden
force-pushed
the
single-lefthook-config
branch
3 times, most recently
from
October 22, 2026 11:58
4f300c9 to
001c764
Compare
eirvandelden
changed the title
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
eirvandelden
force-pushed
the
single-lefthook-config
branch
from
October 22, 2026 19:09
68cb96b to
5f00cfc
Compare
eirvandelden
marked this pull request as ready for review
October 22, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dotfiles
stylelintandeslintchecks runnpx --no stylelintandnpx --no eslint.This repository has neither package nor a config for them, so both checks cannot run here.
The two layouts also fail
erb_lint.stylelintandeslintrun in the repository with their own configs and pass on the existing CSS and JS.Both layouts pass
erb_lint.Implementation
package.json,package-lock.json,stylelint.config.mjs,eslint.config.mjs.app/assets/stylesheets/application.css,app/assets/stylesheets/local/layout/application_page.css,app/assets/stylesheets/local/modules/search_dialog.css.app/javascript/channels/index.js(deleted, dead webpacker file),app/javascript/controllers/clipboard_controller.js.app/views/layouts/application.html.erb,app/views/layouts/admin.html.erb.No lefthook file changes.
Proof
npx --no stylelint "app/assets/stylesheets/**/*.css"andnpx --no eslint .exit 0.erb_lintpasses on both layouts.git diff origin/main --name-onlylists no lefthook file.npm ci --dry-runpasses, so CI'snpm cikeeps working.