Skip to content

Avoid type widening with enum-typed values in FormValue #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmcw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid type widening with enum-typed values in FormValue #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/conform-dom/form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,9 @@ export type DefaultValue<Schema> = Schema extends
? { [Key in keyof Schema]?: DefaultValue<Schema[Key]> } | null | undefined
: string | null | undefined;

export type FormValue<Schema> = Schema extends
| string
| number
| boolean
| Date
| bigint
| null
| undefined
export type FormValue<Schema> = Schema extends string
? Schema | undefined
: Schema extends number | boolean | Date | bigint | null | undefined
? string | undefined
: Schema extends File
? File | undefined
Expand Down