Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Upgrade composer v1 to composer v2 for php 7.4#108

Open
rsereir wants to merge 2 commits into
edbizarro:masterfrom
rsereir:master
Open

Upgrade composer v1 to composer v2 for php 7.4#108
rsereir wants to merge 2 commits into
edbizarro:masterfrom
rsereir:master

Conversation

@rsereir

@rsereir rsereir commented Nov 1, 2020

Copy link
Copy Markdown

Current version for php 7.4 is not compatible with composer v2.0

@edbizarro

edbizarro commented Nov 3, 2020

Copy link
Copy Markdown
Owner

can you remove hirak/prestissimo from the images with composer v2 too?

thanks

@rsereir

rsereir commented Nov 3, 2020

Copy link
Copy Markdown
Author

I removed this image from all php versions with composer v2, thanks for review.

@j3j5 j3j5 mentioned this pull request Nov 4, 2020

@wedi wedi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me after rebasing and resolving confilict with node v14 update.

I'd suggest to let pr #113 overtake and rebase this one afterwards and have it update composer in the PHP 8 version, too.

Edit: I'd probably remove the .idea directory.

@GlennM

GlennM commented May 3, 2021

Copy link
Copy Markdown

PR #113 has been merged, so can this one about Composer v2 be completed now?

@jacobnollette

Copy link
Copy Markdown

Any info on the conflicts?

@evs-xsarus

Copy link
Copy Markdown

Could this be added in such a way that I can choose to have composer 1 or 2 ?

Perhaps keep the current for composer 1

image: edbizarro/gitlab-ci-pipeline-php:7.4

and for composer 2:

image: edbizarro/gitlab-ci-pipeline-php:7.4-composer2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants