Introduce a constantPool cache - #22907
Merged
Merged
Conversation
Contributor
Author
|
jenkisn test sanity alinux64 jdk21 |
Contributor
Author
|
jenkins test sanity alinux64 jdk21 |
Contributor
Author
|
investigating the test failures |
gacholio
reviewed
Nov 10, 2025
tajila
force-pushed
the
opt
branch
3 times, most recently
from
November 10, 2025 16:54
7dd6b83 to
1975eef
Compare
gacholio
reviewed
Nov 10, 2025
| @@ -83,6 +84,15 @@ Java_java_lang_Access_getConstantPool(JNIEnv *env, jclass unusedClass, jobject c | |||
| /* and set the private constantPoolOop member */ | |||
| constantPoolOop = JCL_CACHE_GET(env, FID_sun_reflect_ConstantPool_constantPoolOop); | |||
| (*env)->SetObjectField(env, constantPool, constantPoolOop, classToIntrospect); | |||
Contributor
There was a problem hiding this comment.
Would this not be more efficient done internally? You could avoid multiple trips through enter/exit VM.
tajila
force-pushed
the
opt
branch
20 times, most recently
from
November 13, 2025 18:38
b617406 to
38314f3
Compare
tajila
force-pushed
the
opt
branch
4 times, most recently
from
November 13, 2025 19:22
d451588 to
0ba1e51
Compare
Contributor
Author
|
jenkins test sanity alinux64 jdk21 |
Contributor
Author
|
jenkins test sanity win jdk8 |
Contributor
Author
|
jenkins test sanity.functional win jdk8 |
gacholio
reviewed
Nov 14, 2025
Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled. Signed-off-by: tajila <atobia@ca.ibm.com>
Contributor
Author
|
jenkins test sanity.functional win jdk8 |
Contributor
Author
|
jenkins test sanity,extended.functional,extended.openjdk alinux64 jdk21 |
Contributor
Author
|
jenkins test sanity xlinux jdk17 |
Contributor
Author
|
None of the failures are related to these changes |
tajila
marked this pull request as ready for review
November 17, 2025 20:04
gacholio
approved these changes
Nov 18, 2025
Contributor
|
The failure here on jdk21 seems more than a little similar to the failure in ibmruntimes/openj9-openjdk-jdk21#385: https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_aarch64_mac_Personal_testList_0/245/console |
Contributor
|
Testing for ibmruntimes/openj9-openjdk-jdk17#565 is failing likewise; see https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_sanity.openjdk_ppc64le_linux_Personal_testList_0/67/consoleText |
Contributor
|
The failure is new: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDK21/138 passed (without this change). |
Member
|
Reverted via #22971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the constantPool object off the j.l.Class after the first
invocation of Access::getConstantPool. Given that the ConstantPool
instance is associated with a single version of the class, as soon as
the class is redefined the cache is invalidated and disabled.