Remove vscode-uri bundler workaround - #1240
Merged
Merged
Conversation
Member
Author
|
cc @kaisalmen please retest with your vite config to ensure that the bundling behavior is correct in vite. |
Contributor
|
Thanks, will double check. |
msujew
force-pushed
the
msujew/vscode-uri-3.0.8
branch
from
October 24, 2023 15:32
e49af7e to
39ba1c0
Compare
kaisalmen
approved these changes
Oct 24, 2023
kaisalmen
left a comment
kaisalmen
left a comment
Contributor
There was a problem hiding this comment.
Looking good. I double checked this. Bundling with rollup works. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft has finally released a node (and bundler) compatible ESM version of
vscode-uri(3.0.8). See also microsoft/vscode-uri#39.This change removes the workaround that was needed in Langium to use the values exported by
vscode-uri.