Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6787: Optimize Homepage's CSS - #2649

Closed
theosuja wants to merge 3 commits into
ISAICP-6415from
ISAICP-6787
Closed

ISAICP-6787: Optimize Homepage's CSS#2649
theosuja wants to merge 3 commits into
ISAICP-6415from
ISAICP-6787

Conversation

@theosuja

@theosuja theosuja commented Nov 3, 2021

Copy link
Copy Markdown

No description provided.

@theosuja
theosuja requested review from gingapa and pfrenssen November 3, 2021 08:46
@theosuja

theosuja commented Nov 3, 2021

Copy link
Copy Markdown
Author

I'd need functional team's help for:

  • add "btn btn-secondary" to the button of the "Highlighted event" (since i can't see that content on HP)
  • add "btn btn-secondary" to the "Read more" buttons at the bottom of each card in Explore block (first tab is already working, but I can't figure out how to do it on the other ones)

cc @pfrenssen

@theosuja

theosuja commented Nov 3, 2021

Copy link
Copy Markdown
Author

Note: The !optional statements on _global-search-block.scss must be removed, but this will be handled once this PR is merged with #2633 which modifies that same file. There will be merge conflicts in which we must keep #2633 's changes
image

@gingapa gingapa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@pfrenssen

Copy link
Copy Markdown
Contributor

Looking good but we have moved in the meantime to Gitlab. Closing in favor of https://git.fpfis.eu/digit/digit-joinup-dev/-/merge_requests/43

@pfrenssen pfrenssen closed this Nov 4, 2021
@pfrenssen
pfrenssen deleted the ISAICP-6787 branch November 4, 2021 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants