Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6694: Create the footer menus - allow moderator access - #2610

Open
idimopoulos wants to merge 35 commits into
ISAICP-6415from
ISAICP-6694
Open

ISAICP-6694: Create the footer menus - allow moderator access#2610
idimopoulos wants to merge 35 commits into
ISAICP-6415from
ISAICP-6694

Conversation

@idimopoulos

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread config/sync/block.block.socialmedia.yml Outdated
id: 'system_menu_block:footer-social-media'
label: 'Social media'
provider: system
label_display: visible

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the design mockup, the Social Media menu does not have a label. We can hide it by toggling the label_display option.

Comment thread resources/runner/drupal.yml Outdated
'config_update',
'config_update_ui',
'dblog',
'defautl_content',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module name is misspelled.

Comment thread tests/features/site_menus.feature Outdated
Comment on lines 30 to 31
# Todo: This should become "Contact Joinup Support" in the new theme.
# Ref. https://citnet.tech.ec.europa.eu/CITnet/jira/browse/ISAICP-6694

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this Todo now.

'block-' ~ plugin_id|clean_class,
'col-md-3',
'col-lg-2',
'about-us-menu'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has the class from the About Us menu from which this originates. Let's update this to a unique class that can be used to identify this menu for theming purposes.

Comment on lines 92 to 93
{{ page.footer }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to include a wrapper for the Follow Us and Social Media menus, since in the design mockup they are shown in a single column.

Comment on lines +33 to +34
'col-md-3',
'col-lg-2',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes have a meaning in Bootstrap that these elements will be shown in separate columns. We need to remove them for the Follow Us and Social Media menus, since these 2 menus will be shown together in a single column.

{% endif %}
{{ title_suffix }}
{% block content %}
{{ content }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to find a solution for the links in the Social Media menu so they can be targeted individually by the frontend team to replace them with icons.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants