Symlink include folder instead of files for OpenSSL wrapper - #4199
Open
Flamefire wants to merge 1 commit into
Open
Symlink include folder instead of files for OpenSSL wrapper#4199Flamefire wants to merge 1 commit into
Flamefire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Motivation is the PR for Tensorflow where it was observed on at least 2 systems that the system OpenSSL contained an additional include file after an update which makes compilation using the existing includes fail. E.g.:
To avoid having to rebuild and hence temporarily delete the module we should just symlink the include folder instead of the files.
I did some (mostly consistency ) refactoring while digging through the source:
pathlib.Pathwhere paths are storedself.namein the only place where raw "openssl" was used in the include folder names (we should either use it always or never)is_system_sslproperty instead of duplicating the same checkCounterargument is this comment by @boegel in 2897480 of #2429:
It seems to clarify that explicit decision in 9feaf55 see #2429 (comment)
Maybe this does not apply to the headers or not anymore? @lexming
Requires:
Paths inmkdirand cleanup easybuild-framework#5233dir_contains_fileseasybuild-framework#5236 (otherwise CPATH won't be set)