Skip to content

feat: add irts file module, and test file - #14

Open
samuelbravi11 wants to merge 9 commits into
devfrom
feature/irts
Open

feat: add irts file module, and test file#14
samuelbravi11 wants to merge 9 commits into
devfrom
feature/irts

Conversation

@samuelbravi11

@samuelbravi11 samuelbravi11 commented Jun 24, 2026

Copy link
Copy Markdown

Purpose

Implement IRTS module.

Overview

Irts files and unit test.

Guidance

Irts files and unit test.

Comment thread Core/Inc/das/irts.h Outdated
Comment thread Core/Inc/das/irts-api.h Outdated
Comment thread platformio.ini Outdated
Comment thread Core/Src/das/irts-api.c Outdated
Comment thread Core/Inc/das/irts.h Outdated
Comment on lines +28 to +29
EAGLETRT_VOLATILE double left_temperature;
EAGLETRT_VOLATILE double right_temperature;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have the irts names you can use them as indices for an array instead of having the two independent temperatures.

@Bridiro Bridiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I won't add more comments as everything seems already addressed.

One quick note on double. Even if it's fine on normal PCs, on MCUs as STM32, 32 is the architecture, and this means they work fine for 32 bits sized types (uint32_t, float...) but as we studied in Calcolatori last year, they need more than one instruction to operate on bigger values (e.g. double...), and this means the operation is not atomic. While the single-time operation cost is probably negligible, the power constraints are big on MCUs and we might as well keep the usage as low as possible.

@Bridiro Bridiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much to say here

Comment thread Core/Src/das/irts-api.c Outdated
Comment thread Core/Inc/das/irts-api.h Outdated
Comment thread Core/Inc/das/irts.h Outdated
samuelbravi11 and others added 2 commits July 12, 2026 13:22
Co-authored-by: Alessandro Bridi <ale.bridi15@gmail.com>
@samuelbravi11
samuelbravi11 requested a review from Tonidotpy July 12, 2026 11:36
Comment thread Core/Src/das/irts-api.c Outdated
Comment thread Core/Src/das/irts-api.c Outdated
Comment thread test/test_irts_api/test_irts_api.c Outdated
Comment thread test/test_irts_api/test_irts_api.c Outdated
Comment thread test/test_irts_api/test_irts_api.c Outdated
Comment thread test/test_irts_api/test_irts_api.c Outdated
samuelbravi11 and others added 3 commits July 15, 2026 13:53
Co-authored-by: Antonio Gelain <61268285+Tonidotpy@users.noreply.github.com>
Co-authored-by: Antonio Gelain <61268285+Tonidotpy@users.noreply.github.com>
@samuelbravi11
samuelbravi11 requested a review from Tonidotpy July 15, 2026 12:10

@Tonidotpy Tonidotpy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix

Comment thread test/test_irts_api/test_irts_api.c Outdated

@Bridiro Bridiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

samuelbravi11 and others added 2 commits July 20, 2026 12:38
Co-authored-by: Antonio Gelain <61268285+Tonidotpy@users.noreply.github.com>
@samuelbravi11
samuelbravi11 requested a review from Tonidotpy July 20, 2026 10:44
@samuelbravi11 samuelbravi11 linked an issue Jul 20, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: implement irst module

3 participants