Fix garbage_ratio_pct truncation for chunks with very few defrag blocks - #441
Merged
Conversation
Use float instead of uint32_t for garbage_ratio_pct so that chunks with a small defrag_blks count (e.g. 1 block out of 200) are not silently rounded to 0 and excluded from GC even when gc_thresh is set to 0. Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #441 +/- ##
==============================================
Coverage ? 54.15%
==============================================
Files ? 36
Lines ? 5423
Branches ? 687
==============================================
Hits ? 2937
Misses ? 2183
Partials ? 303 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use float instead of uint32_t for garbage_ratio_pct so that chunks with a small defrag_blks count (e.g. 1 block out of 200) are not silently rounded to 0 and excluded from GC even when gc_thresh is set to 0.