Skip to content

Remove DEBUG_ASSERT for gc_thresh_low <= gc_thresh_high - #440

Merged
xiaoxichen merged 1 commit into
eBay:stable/v4.xfrom
xiaoxichen:quick-fix
Jun 24, 2026
Merged

Remove DEBUG_ASSERT for gc_thresh_low <= gc_thresh_high#440
xiaoxichen merged 1 commit into
eBay:stable/v4.xfrom
xiaoxichen:quick-fix

Conversation

@xiaoxichen

Copy link
Copy Markdown
Collaborator

As we have auto adjust, it is unnecessary to have the debug assert

As we have auto adjust, it is unnecessary to have the debug assert

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@xiaoxichen
xiaoxichen requested a review from JacksonYao287 June 24, 2026 08:03

@JacksonYao287 JacksonYao287 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxichen
xiaoxichen merged commit 9b51a62 into eBay:stable/v4.x Jun 24, 2026
24 of 25 checks passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (stable/v4.x@6722a38). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##             stable/v4.x     #440   +/-   ##
==============================================
  Coverage               ?   54.03%           
==============================================
  Files                  ?       36           
  Lines                  ?     5417           
  Branches               ?      681           
==============================================
  Hits                   ?     2927           
  Misses                 ?     2188           
  Partials               ?      302           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants