Pause state machine before pg_destroy in BR - #326
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 63.15% 61.95% -1.20%
==========================================
Files 32 35 +3
Lines 1900 4114 +2214
Branches 204 504 +300
==========================================
+ Hits 1200 2549 +1349
- Misses 600 1293 +693
- Partials 100 272 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
is ths ready for review? |
0ccf7a0 to
bdcae36
Compare
|
please rebase this PR and update the conan version |
JacksonYao287
left a comment
JacksonYao287
left a comment
There was a problem hiding this comment.
other parts looks good, one one minor comment
| std::this_thread::sleep_for(std::chrono::milliseconds(delay.get())); | ||
| } | ||
| // It's an inifinite loop until the state machine resumes. | ||
| home_object_->resume_pg_state_machine(m_snp_rcv_handler->get_context_pg_id()); |
There was a problem hiding this comment.
I am not sure do we need to resume pg state machine explictly, since after snapshot is applied, nuraft will resume statemachine
There was a problem hiding this comment.
Seems no need to resume explicitly, comment it out.
4 participants
No description provided.