Skip to content

enhance create_pg - #325

Merged
Besroy merged 1 commit into
eBay:mainfrom
Besroy:creat_pg
Jul 14, 2025
Merged

enhance create_pg#325
Besroy merged 1 commit into
eBay:mainfrom
Besroy:creat_pg

Conversation

@Besroy

@Besroy Besroy commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

@Besroy
Besroy force-pushed the creat_pg branch 3 times, most recently from 28bb882 to 9e1ed56 Compare July 10, 2025 13:10
@codecov-commenter

codecov-commenter commented Jul 10, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (1746bcc) to head (0f459c2).
⚠️ Report is 168 commits behind head on main.

Files with missing lines Patch % Lines
src/include/homeobject/pg_manager.hpp 41.17% 9 Missing and 1 partial ⚠️
src/lib/homestore_backend/hs_pg_manager.cpp 80.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   63.15%   62.58%   -0.58%     
==========================================
  Files          32       35       +3     
  Lines        1900     4084    +2184     
  Branches      204      499     +295     
==========================================
+ Hits         1200     2556    +1356     
- Misses        600     1257     +657     
- Partials      100      271     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yuwmao
yuwmao previously approved these changes Jul 11, 2025

@yuwmao yuwmao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Besroy
Besroy force-pushed the creat_pg branch 2 times, most recently from e9a3bb9 to d7d6eb2 Compare July 11, 2025 07:58

@yuwmao yuwmao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Besroy
Besroy merged commit 326a454 into eBay:main Jul 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants