adapt to destroying pg for gc - #324
Merged
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 63.15% 62.17% -0.99%
==========================================
Files 32 35 +3
Lines 1900 4148 +2248
Branches 204 508 +304
==========================================
+ Hits 1200 2579 +1379
- Misses 600 1293 +693
- Partials 100 276 +176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
2 times, most recently
from
July 9, 2025 09:44
0928734 to
cc2f56a
Compare
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
from
July 10, 2025 08:51
cc2f56a to
cfbf9ba
Compare
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
from
July 10, 2025 09:00
cfbf9ba to
70858d1
Compare
JacksonYao287
changed the title
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
from
July 11, 2025 07:38
1c9e525 to
d1eb790
Compare
JacksonYao287
commented
Jul 14, 2025
| LOGD("fetch data with blob_id={}, shard=0x{:x}", blob_id, shard_id); | ||
| // we first try to read data according to the local_blk_id to see if it matches the blob_id | ||
| return std::move(homestore::data_service().async_read(local_blk_id, given_buffer, total_size)) | ||
| .via(folly::getGlobalIOExecutor()) |
Member
Author
There was a problem hiding this comment.
there is a case that folly::getGlobalIOExecutor() will throw an exception.
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
from
July 14, 2025 08:27
ba550f7 to
a294ca3
Compare
JacksonYao287
force-pushed
the
gc-destroy-pg
branch
from
July 16, 2025 08:24
a294ca3 to
1eaf87d
Compare
xiaoxichen
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapt to destroy pg for gc. after the pr is merged, there is not feature gap for gc, so enable gc by default