Skip to content

Change task_id to string - #316

Merged
JacksonYao287 merged 1 commit into
eBay:mainfrom
yuwmao:taskid
Jul 1, 2025
Merged

Change task_id to string#316
JacksonYao287 merged 1 commit into
eBay:mainfrom
yuwmao:taskid

Conversation

@yuwmao

@yuwmao yuwmao commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

This pr is the adaption change for eBay/HomeStore#758

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (1746bcc) to head (ffb5437).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_pg_manager.cpp 80.00% 1 Missing ⚠️
src/lib/memory_backend/mem_pg_manager.cpp 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   63.15%   62.65%   -0.51%     
==========================================
  Files          32       35       +3     
  Lines        1900     3976    +2076     
  Branches      204      480     +276     
==========================================
+ Hits         1200     2491    +1291     
- Misses        600     1226     +626     
- Partials      100      259     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuwmao
yuwmao marked this pull request as ready for review June 27, 2025 11:32

@Besroy Besroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonYao287
JacksonYao287 merged commit 034c7f9 into eBay:main Jul 1, 2025
90 of 96 checks passed
xiaoxichen pushed a commit that referenced this pull request Jul 3, 2025
xiaoxichen added a commit that referenced this pull request Jul 3, 2025
xiaoxichen added a commit that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants