Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Provider/EntityProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ public function find(
$this->class
);

return $find->many ? $references[0] ?? null : $references;
return !$find->many ? $references[0] ?? null : $references;
}
}
111 changes: 111 additions & 0 deletions tests/Feature/Resolver/AsDoctrineReferenceDtoTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
<?php

declare(strict_types=1);

namespace DualMedia\DtoRequestBundle\Tests\Feature\Resolver;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Tools\SchemaTool;
use DualMedia\DtoRequestBundle\Resolve\DtoResolver;
use DualMedia\DtoRequestBundle\Tests\Fixture\Dto\AsDoctrineReferenceManyDto;
use DualMedia\DtoRequestBundle\Tests\Fixture\Dto\AsDoctrineReferenceOneDto;
use DualMedia\DtoRequestBundle\Tests\Fixture\Entity\SimpleEntity;
use DualMedia\DtoRequestBundle\Tests\PHPUnit\KernelTestCase;
use PHPUnit\Framework\Attributes\Group;
use Symfony\Component\HttpFoundation\Request;

#[Group('feature')]
#[Group('resolver')]
class AsDoctrineReferenceDtoTest extends KernelTestCase
{
private DtoResolver $resolver;

private EntityManagerInterface $em;

protected function setUp(): void
{
$this->resolver = static::getService(DtoResolver::class);
$this->em = static::getService(EntityManagerInterface::class);

new SchemaTool($this->em)->createSchema(
$this->em->getMetadataFactory()->getAllMetadata()
);
}

protected function tearDown(): void
{
new SchemaTool($this->em)->dropSchema(
$this->em->getMetadataFactory()->getAllMetadata()
);

parent::tearDown();
}

public function testFindOneByAsReferenceReturnsSingleEntity(): void
{
$entity = $this->createEntity();

$dto = $this->resolver->resolve(
AsDoctrineReferenceOneDto::class,
new Request(request: ['inputId' => (string)$entity->getId()])
);

static::assertTrue($dto->isValid(), (string)$dto->getConstraintViolationList());
static::assertInstanceOf(SimpleEntity::class, $dto->entity);
static::assertSame($entity->getId(), $dto->entity->getId());
}

public function testFindOneByAsReferenceReturnsNullWhenMissing(): void
{
$dto = $this->resolver->resolve(
AsDoctrineReferenceOneDto::class,
new Request(request: ['inputId' => '99999'])
);

static::assertTrue($dto->isValid());
static::assertNull($dto->entity);
}

public function testFindByAsReferenceReturnsListOfEntities(): void
{
$a = $this->createEntity();
$b = $this->createEntity();

$dto = $this->resolver->resolve(
AsDoctrineReferenceManyDto::class,
new Request(request: [
'inputIds' => [(string)$a->getId(), (string)$b->getId()],
])
);

static::assertTrue($dto->isValid(), (string)$dto->getConstraintViolationList());
static::assertCount(2, $dto->entities);
$ids = array_map(static fn (SimpleEntity $e): int|null => $e->getId(), $dto->entities);
sort($ids);
static::assertSame([$a->getId(), $b->getId()], $ids);

foreach ($dto->entities as $entity) {
static::assertInstanceOf(SimpleEntity::class, $entity);
}
}

public function testFindByAsReferenceReturnsEmptyListForUnknownIds(): void
{
$dto = $this->resolver->resolve(
AsDoctrineReferenceManyDto::class,
new Request(request: ['inputIds' => ['99998', '99999']])
);

static::assertTrue($dto->isValid());
static::assertSame([], $dto->entities);
}

private function createEntity(): SimpleEntity
{
$entity = new SimpleEntity();
$this->em->persist($entity);
$this->em->flush();

return $entity;
}
}
23 changes: 23 additions & 0 deletions tests/Fixture/Dto/AsDoctrineReferenceManyDto.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php

declare(strict_types=1);

namespace DualMedia\DtoRequestBundle\Tests\Fixture\Dto;

use DualMedia\DtoRequestBundle\Dto\AbstractDto;
use DualMedia\DtoRequestBundle\Dto\Attribute\AsDoctrineReference;
use DualMedia\DtoRequestBundle\Dto\Attribute\Field;
use DualMedia\DtoRequestBundle\Dto\Attribute\FindBy;
use DualMedia\DtoRequestBundle\Tests\Fixture\Entity\SimpleEntity;
use DualMedia\DtoRequestBundle\Type\TypeUtils;

class AsDoctrineReferenceManyDto extends AbstractDto
{
/**
* @var list<SimpleEntity>
*/
#[FindBy]
#[AsDoctrineReference]
#[Field('id', 'inputIds', TypeUtils::LIST_INT)]
public array $entities = [];
}
19 changes: 19 additions & 0 deletions tests/Fixture/Dto/AsDoctrineReferenceOneDto.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

declare(strict_types=1);

namespace DualMedia\DtoRequestBundle\Tests\Fixture\Dto;

use DualMedia\DtoRequestBundle\Dto\AbstractDto;
use DualMedia\DtoRequestBundle\Dto\Attribute\AsDoctrineReference;
use DualMedia\DtoRequestBundle\Dto\Attribute\Field;
use DualMedia\DtoRequestBundle\Dto\Attribute\FindOneBy;
use DualMedia\DtoRequestBundle\Tests\Fixture\Entity\SimpleEntity;

class AsDoctrineReferenceOneDto extends AbstractDto
{
#[FindOneBy]
#[AsDoctrineReference]
#[Field('id', 'inputId')]
public SimpleEntity|null $entity = null;
}
6 changes: 3 additions & 3 deletions tests/Unit/Provider/EntityProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ public function testFindAsReference(): void
new AsDoctrineReference(),
]);

static::assertSame($references, $result);
static::assertSame($references[0], $result);
}

public function testFindByAsReferenceMany(): void
{
$criteria = ['status' => 'active'];
$qb = $this->createMock(QueryBuilder::class);
$builtQb = $this->createMock(QueryBuilder::class);
$references = [[new \stdClass()]];
$references = [new \stdClass()];

$this->getMockedService(EntityRepository::class)
->method('createQueryBuilder')
Expand All @@ -157,6 +157,6 @@ public function testFindByAsReferenceMany(): void
new AsDoctrineReference(),
]);

static::assertSame($references[0], $result);
static::assertSame($references, $result);
}
}
Loading