Skip to content

SqlServerDsc: Fix Pester 6 syntax in integration tests #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johlju merged 1 commit into from
Jul 12, 2026
Merged

SqlServerDsc: Fix Pester 6 syntax in integration tests #2468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- SqlServerDsc
- Several integration tests wrongly said that the command `Test-DscConfiguration`
return `$true` when it is in fact return the string value `'True'`.
- Some integration tests still wasn't converted correctly to Pester 6 syntax

@coderabbitai coderabbitai Bot Jul 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix the changelog grammar.

Use “Some integration tests still weren’t converted correctly to Pester 6 syntax.”

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` at line 18, Update the changelog entry to use the grammatically
correct “weren’t” in place of “wasn’t,” preserving the rest of the wording and
Pester 6 reference.

Source: Path instructions

- DSC_SqlRS and DSC_SqlWindowsFirewall
- Fixed a duplicated word in localized `TestFailedAfterSet` messages.
- SqlServerDsc
Expand Down
8 changes: 4 additions & 4 deletions tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}
}

$webRequestStatusCode | Should-BeString -CaseSensitive 200
$webRequestStatusCode | Should-Be 200
}

It 'Should be able to access the Reports site without any error' {
Expand Down Expand Up @@ -291,7 +291,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}
}

$webRequestStatusCode | Should-BeString -CaseSensitive 200
$webRequestStatusCode | Should-Be 200
}
}

Expand Down Expand Up @@ -473,7 +473,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}
}

$webRequestStatusCode | Should-BeString -CaseSensitive 200
$webRequestStatusCode | Should-Be 200
}

It 'Should be able to access the Reports site without any error' {
Expand Down Expand Up @@ -535,7 +535,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}
}

$webRequestStatusCode | Should-BeString -CaseSensitive 200
$webRequestStatusCode | Should-Be 200
}
}

Expand Down
8 changes: 4 additions & 4 deletions tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',

$resourceCurrentState.Ensure | Should-Be 'Present'
$resourceCurrentState.ServerRoleName | Should-Be $ConfigurationData.AllNodes.Role3Name
$resourceCurrentState.Members | Should-Be @(
$resourceCurrentState.Members | Should-BeCollection @(
$ConfigurationData.AllNodes.User1Name
$ConfigurationData.AllNodes.User2Name
)
Expand Down Expand Up @@ -265,7 +265,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
$resourceCurrentState.Ensure | Should-Be 'Present'
$resourceCurrentState.ServerRoleName | Should-Be $ConfigurationData.AllNodes.Role1Name

$resourceCurrentState.Members | Should-Be @(
$resourceCurrentState.Members | Should-BeCollection @(
$ConfigurationData.AllNodes.User1Name
$ConfigurationData.AllNodes.User2Name
)
Expand Down Expand Up @@ -324,7 +324,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
$resourceCurrentState.Ensure | Should-Be 'Present'
$resourceCurrentState.ServerRoleName | Should-Be $ConfigurationData.AllNodes.Role2Name

$resourceCurrentState.Members | Should-Be @(
$resourceCurrentState.Members | Should-BeCollection @(
$ConfigurationData.AllNodes.User1Name
$ConfigurationData.AllNodes.User2Name
$ConfigurationData.AllNodes.User4Name
Expand Down Expand Up @@ -509,7 +509,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
}

$currentState.Ensure | Should-Be 'Present'
$currentState.Members | Should-Be @($testMemberName)
$currentState.Members | Should-BeCollection @($testMemberName)
$currentState.MembersToInclude | Should-BeFalsy
$currentState.MembersToExclude | Should-BeFalsy
}
Expand Down
6 changes: 3 additions & 3 deletions tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
$resourceCurrentState.SourcePath | Should-Be $ConfigurationData.AllNodes.SourcePath
$resourceCurrentState.DatabaseEngineFirewall | Should-BeTrue
$resourceCurrentState.BrowserFirewall | Should-BeTrue
$resourceCurrentState.ReportingServicesFirewall | Should-BeFalse
$resourceCurrentState.AnalysisServicesFirewall | Should-BeFalse
$resourceCurrentState.IntegrationServicesFirewall | Should-BeFalse
$resourceCurrentState.ReportingServicesFirewall | Should-BeNull
$resourceCurrentState.AnalysisServicesFirewall | Should-BeFalsy
$resourceCurrentState.IntegrationServicesFirewall | Should-BeFalsy
}

It 'Should return True when Test-DscConfiguration is run' {
Expand Down
Loading