This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Adds instructions for adding Nightwatch capability to local environment - #196
Draft
mradcliffe wants to merge 2 commits into
Draft
Adds instructions for adding Nightwatch capability to local environment#196mradcliffe wants to merge 2 commits into
mradcliffe wants to merge 2 commits into
Conversation
rfay
suggested changes
Mar 26, 2021
rfay
left a comment
rfay
left a comment
Member
There was a problem hiding this comment.
I'm in favor of this, but it will have to have tests (quicksprint tests) that prove that it keeps working as time moves on. Otherwise it won't be maintainable.
mradcliffe
marked this pull request as draft
March 26, 2021 17:48
Member
|
Shouldn't we be adding Nightwatch capability, not just instructions? |
Collaborator
Author
|
I wasn't sure if we wanted to make it the default or not. Is there any risks for performance? |
Member
|
Do people usually need nightwatch? If so, I'd say add it. I don't think performance would be affected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192
This is probably more of a Proof of Concept that might be closed.
I didn't think we would want to add the chromedriver image as that would increase the package size, but maybe we do want this to be the default experience?