Fix issue #357: Output MegaDetector category labels instead of numeric IDs - #391
Open
LenaPerry wants to merge 1 commit into
Open
Fix issue #357: Output MegaDetector category labels instead of numeric IDs#391LenaPerry wants to merge 1 commit into
LenaPerry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #357, ensuring that Zamba outputs the string labels (“animal”, “person”, “vehicle”) for MegaDetector detections instead of the default numeric category IDs (1, 2, 3).
As mentioned in the issue, MegaDetector does output with a detection_categories mapping, but the generate_detections_one_image() output does not include that dictionary. Since Zamba uses the default MD model (MDV5A) and does not override category mappings anywhere, these defaults always apply. Thus I implemented the mapping of 1: animal, 2: person, 3: vehicle within manager.py to change the output the user sees.
I have tested it and it can identify all three categories within images and output the correct label rather than numeric ID.