Skip to content

Uncouple Multiprocessing Settings - Issue #240 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronphilip19 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Uncouple Multiprocessing Settings - Issue #240 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d2a72b
Update utils.py
aaronphilip19 Apr 25, 2024
80fe01b
Update utils.py - Setting multiprocessor base context - Issue#240
aaronphilip19 Apr 26, 2024
e34c71f
Update model_manager.py - trainer config change - Issue #240
aaronphilip19 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions zamba/models/model_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,19 +280,17 @@ def train_model(

accelerator, devices = configure_accelerator_and_devices_from_gpus(train_config.gpus)


multiprocessing_strategy = getattr(train_config,"multiprocessing_strategy",None)

trainer = pl.Trainer(
accelerator=accelerator,
devices=devices,
max_epochs=train_config.max_epochs,
logger=tensorboard_logger,
callbacks=callbacks,
fast_dev_run=train_config.dry_run,
strategy=(
DDPStrategy(find_unused_parameters=False)
if (data_module.multiprocessing_context is not None) and (train_config.gpus > 1)
else "auto"
),
strategy = multiprocessing_strategy,
)
#Set the strategy within trainer to reflect changes

if video_loader_config.cache_dir is None:
logger.info("No cache dir is specified. Videos will not be cached.")
Expand Down
7 changes: 2 additions & 5 deletions zamba/pytorch_lightning/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,8 @@ def __init__(
transform=transform,
video_loader_config=video_loader_config,
)
self.multiprocessing_context: BaseContext = (
None
if (multiprocessing_context is None) or (num_workers == 0)
else multiprocessing_context
)
self.multiprocessing_context: BaseContext = multiprocessing_context #Modified the multiprocessing context to not factor in num_workers decoupliing it


super().__init__(*args, **kwargs)

Expand Down